cshannon opened a new pull request, #1389:
URL: https://github.com/apache/activemq/pull/1389

   Switch to using an AtomicInteger for tracking bytes received in a 
TcpTransport. This makes incrementing the counter an atomic operation. 
Previously a volatile int was used and incrementing volatiles is not atomic 
because it's a 3 step process of read, update, set.
   
   This also makes a small fix to ensure that the full initialization buffer 
will always be entirely read and processed when using the auto+nio+ssl 
transport. Previous the code assumed only the first command was stored in the 
initialization buffer but technically more bytes could exist for a future 
command (even if unlikely with the current Java implementation).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to