tabish121 commented on code in PR #5493:
URL: https://github.com/apache/activemq-artemis/pull/5493#discussion_r1955342002
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationConfiguration.java:
##########
@@ -76,12 +77,20 @@ public final class AMQPFederationConfiguration {
public static final boolean DEFAULT_IGNNORE_QUEUE_CONSUMER_PRIORITIES =
false;
/**
- * Default timeout (milliseconds) applied to federation receivers that are
being closed due to removal
+ * Default timeout (milliseconds) applied to federation receivers that are
being stopped due to removal
* of local demand and need to drain link credit and process any in-flight
deliveries before closure.
* If the timeout elapses before the link has quiesced the link is forcibly
closed.
*/
public static final int DEFAULT_RECEIVER_QUIESCE_TIMEOUT = 60_000;
+ /**
+ * Default timeout (milliseconds) applied to federation receivers that have
been stopped due to lack of
+ * local demand. The close delay prevent a link from detaching in cases
where demand drops and returns
+ * in quick succession allowing for faster recovery. The idle timeout kicks
in once the link has completed
+ * its drain of outstanding credit.
+ */
+ public static final int DEFAULT_RECEIVER_IDLE_TIMEOUT = 60_000;
Review Comment:
I've added a commit which splits the timeout into two separate properties
one for address and one for queues with the 60s value for queue consumer and a
much reduced 5s value for address consumers. I chose not to retain a top level
receiver idle timeout that applied to both at the federation configuration
level as that may just make it more confusing in the end.
If this looks good I will squash the two commits but I kept it split for now
to show the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
