gemmellr commented on PR #5499: URL: https://github.com/apache/activemq-artemis/pull/5499#issuecomment-2659076398
> I replaced this test with the test testSendMessageWithLargeHeader in the existing ReplicationTest class because there isn't anything specific to AMQP as pointed out by @gemmellr and @clebertsuconic. I also added the unit test ReplicatedJournalTest to validate the invocation order of all append and tryApppend methods. Sorry if I wasn't clear originally, I had no problem with the test _using_ AMQP and wasn't at all meaning it needed rewritten for an existing class. I just thought it should sit in a package aimed at testing replication/journal if thats what it was aiming to test. Thanks for the unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
