clebertsuconic commented on code in PR #5498:
URL: https://github.com/apache/activemq-artemis/pull/5498#discussion_r1960371451
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -85,7 +86,8 @@ public class PagingStoreImpl implements PagingStore {
private final PageCache usedPages = new PageCache(this);
- //it's being guarded by lock.writeLock().lock() and never read concurrently
+ // This is updated and read by the PageTimedWriter's executor thread
+ // or by a writeLock if the timedWriter is null
Review Comment:
1 is reload, which does not count (broker is not started yet)
2 directWritePage is called within the page executor
3 openNewPage is called within the page executor as well
2 and 3 will use a writeLock if the timedWriter == null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
