tabish121 commented on code in PR #5512:
URL: https://github.com/apache/activemq-artemis/pull/5512#discussion_r1964119961
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/PagingLeakTest.java:
##########
@@ -51,7 +51,9 @@
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
-/* at the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked list (or leaked-list, pun intended)
*/
+/* At the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked
Review Comment:
Could perhaps add a newline after the opening '/*' to bring this into
compliance with all the other formatting changes.
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/JournalLeakTest.java:
##########
@@ -53,7 +53,9 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/* at the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked list (or leaked-list, pun intended)
*/
+/* At the time this test was written JournalFileImpl was leaking through
JournalFileImpl::negative creating a linked
Review Comment:
Should perhaps add a newline after the opening '/*' to be consistent with
other changes.
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/json/JsonValue.java:
##########
@@ -57,10 +56,7 @@ public interface JsonValue {
String toString();
enum ValueType {
- ARRAY,
- OBJECT, STRING, NUMBER,
- TRUE, FALSE,
- NULL
+ ARRAY, OBJECT, STRING, NUMBER, TRUE, FALSE, NULL
Review Comment:
This doesn't appear to be javadoc related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
