clebertsuconic commented on code in PR #5498:
URL: https://github.com/apache/activemq-artemis/pull/5498#discussion_r1968344317
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -731,17 +800,21 @@ private void resetCurrentPage(Page newCurrentPage) {
@Override
public void stopPaging() {
logger.debug("stopPaging being called, while isPaging={} on {}",
this.paging, this.storeName);
- lock.writeLock().lock();
+ writeLock();
try {
final boolean isPaging = this.paging;
if (isPaging) {
+ if (timedWriter.hasPendingIO()) {
+ logger.debug("There are pending timed writes. Cannot clear
paging now.");
Review Comment:
This condition should not happen.. we should not call stopPaging if there
are pending IO.
As a matter of fact I found one possible caller where this could happen from
clearCompleteMiddleStream, and I'm also checking in there.
I will add an assert clause in there as well, at least we would capture it
during the testsuite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
