jbertram commented on code in PR #5533: URL: https://github.com/apache/activemq-artemis/pull/5533#discussion_r1972434176
########## artemis-commons/pom.xml: ########## @@ -83,6 +83,10 @@ <groupId>commons-beanutils</groupId> <artifactId>commons-beanutils</artifactId> </dependency> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>artemis-boot</artifactId> Review Comment: I understand you want access to the constant, but forfeiting the purity of `artemis-commons`'s dependencies seems a high price to pay. It would make more sense for `artemis-boot` to depend on `artemis-commons` instead of the other way around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact