arayq2 commented on PR #21:
URL: https://github.com/apache/activemq-cpp/pull/21#issuecomment-2692405960
I'm not sure that setting CCXFLAGS inside configure.ac is the right way to
go. The code base compiles cleanly with C++11. The issue I fixed was that
compilation was failing for C++17; now it doesn't. There is no need to
_insist_ on C++17. In fact, as far as I know, C++20 would fail only because
'throw()' is no longer recognized as an alias for 'noexcept'. A global SAR
one-liner can fix that as well.
Also, the GCC docs state that C++17 is the default setting for GCC 11, so
not setting -std at all will compile under C++17 - it's the -ansi setting
that's screwing things up. Just let people use whatever version of GCC they
have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
