clebertsuconic commented on code in PR #5537:
URL: https://github.com/apache/activemq-artemis/pull/5537#discussion_r1979748492
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java:
##########
@@ -775,6 +776,7 @@ public void testMaxSize() throws Exception {
assertEquals(10 * 1024 * 1024, configuration.getGlobalMaxSize());
assertEquals(1000, configuration.getGlobalMaxMessages());
+ assertEquals(30, configuration.getGlobalMaxSizePercentOfJvmMaxMemory());
Review Comment:
actually when I wrote this I thought this was the place where you would
validate broker properties.
shouldn't you also configure this by the properties on
ConfigurationimplTest, just in case.. on that case you should use a different
constant other than 30.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
