clebertsuconic commented on code in PR #5557:
URL: https://github.com/apache/activemq-artemis/pull/5557#discussion_r1994046912
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java:
##########
@@ -610,9 +610,24 @@ public void testRedeployBridge() throws Exception {
Queue queue = session.createQueue("c-from");
MessageProducer producer = session.createProducer(queue);
producer.send(session.createMessage());
- Wait.assertEquals(1, () ->
embeddedActiveMQ.getActiveMQServer().locateQueue("c-to").getMessageCount());
+ Wait.assertEquals(1, () ->
embeddedActiveMQ.getActiveMQServer().locateQueue("c-to").getMessageCount(),
2000);
}
+ brokerXML.toFile().setLastModified(System.currentTimeMillis() + 1000);
+ latch.setCount(1);
+ embeddedActiveMQ.getActiveMQServer().getReloadManager().setTick(tick);
+ latch.await(10, TimeUnit.SECONDS);
+ Thread.sleep(5000);
Review Comment:
These sleeps are a bit trouble on the extended testsuite...
If you need some condition to happen, I would recommend some Wait.assert
clause... and only waiting the required time. or making retries faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
