tabish121 commented on code in PR #5562:
URL: https://github.com/apache/activemq-artemis/pull/5562#discussion_r2001806883
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##########
@@ -2437,6 +2437,9 @@ public boolean closeSessionWithID(final String
connectionID, final String ID, fi
List<ServerSession> sessions = server.getSessions(connectionID);
for (ServerSession session : sessions) {
if (session.getName().equals(ID)) {
+ for (ServerConsumer consumer : session.getServerConsumers())
{
Review Comment:
If for some reason the consumer itself threw an exception out of the
disconnect call then the follow on session close would not happen, is that
intended? One option would be to catch and hold the first exception and finish
closing all consumers and the session before firing a caught exception if the
end goal is to always ensure the session is closed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
