Havret commented on code in PR #93:
URL: https://github.com/apache/activemq-nms-amqp/pull/93#discussion_r2032068610
##########
src/NMS.AMQP/NmsConnectionFactory.cs:
##########
@@ -367,6 +375,9 @@ private void SetUriOptions(StringDictionary options)
{
StringDictionary nmsOptions =
PropertyUtil.FilterProperties(options, "nms.");
PropertyUtil.SetProperties(this, nmsOptions);
+
+ StringDictionary amqpOptions =
PropertyUtil.FilterProperties(options, "amqp.");
Review Comment:
This is actually already implemented in `AmqpProviderFactory`. The only
change needed is to add an additional property to the `AmqpProvider` class.
That should allow the `vhost` property to be propagated appropriately.
It shouldn't be configured at the connection level—it belongs on the AMQP
provider (at least that's how it's handled in Qpid).
You can refer to this snippet for context:
https://github.com/apache/qpid-jms/blob/a248f02a21e1c9ca362fe317ad581d662c71d62c/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java#L1281-L1291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
