jbertram commented on code in PR #5587:
URL: https://github.com/apache/activemq-artemis/pull/5587#discussion_r2034027629
##########
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java:
##########
@@ -309,16 +311,18 @@ private ServerConnector
createServerConnector(HttpConfiguration httpConfiguratio
addStoreResourceScannerTask(binding.getTrustStorePath(),
binding.getTrustStoreType(), sslFactory);
}
- SslConnectionFactory sslConnectionFactory = new
SslConnectionFactory(sslFactory, "HTTP/1.1");
-
SecureRequestCustomizer secureRequestCustomizer = new
SecureRequestCustomizer();
secureRequestCustomizer.setSniHostCheck(binding.getSniHostCheck() !=
null ? binding.getSniHostCheck() : DEFAULT_SNI_HOST_CHECK_VALUE);
secureRequestCustomizer.setSniRequired(binding.getSniRequired() !=
null ? binding.getSniRequired() : DEFAULT_SNI_REQUIRED_VALUE);
httpConfiguration.addCustomizer(secureRequestCustomizer);
httpConfiguration.setSendServerVersion(false);
HttpConnectionFactory httpFactory = new
HttpConnectionFactory(httpConfiguration);
- connector = new ServerConnector(server, sslConnectionFactory,
httpFactory);
+ HTTP2ServerConnectionFactory h2 = new
HTTP2ServerConnectionFactory(httpConfiguration);
+ ALPNServerConnectionFactory alpn = new ALPNServerConnectionFactory();
+ alpn.setDefaultProtocol("HTTP/1.1");
Review Comment:
Fixed! Thanks for the suggestion.
##########
artemis-pom/pom.xml:
##########
@@ -554,6 +554,12 @@
<version>${jetty-servlet-api.version}</version>
<!-- License: (Joint): Apache 2.0 or EPL 2.0 -->
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty.http2</groupId>
+ <artifactId>jetty-http2-server</artifactId>
+ <version>${jetty.version}</version>
+ <!-- License: (Joint): Apache 2.0 or EPL 2.0 -->
+ </dependency>
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
