cshannon opened a new pull request, #1419:
URL: https://github.com/apache/activemq/pull/1419
This commit makes several improvements and fixes for syncing durable
subscriptions when a network bridge connects.
1) A bug was fixed during durable sync that would cause the clientId to not
always be included for durables in the subscription list which could cause a
loop to be created as the other broker would not be able to tell where the
network subscription came from.
2) During reactivation when dynamicOnly is false and durable sync is set to
true, we make sure to include the TTL information (full broker path) from the
online consumer attached to durables so that TTL info is properly
propagated so we don't incorrectly create demand. Thisonly works if
consumers are online, so for TTL > 1 it is still recommended to set
dynamicOnly to true and allow only online consumers drive demand.
3) For TTL 1, we can handle sync correctly on restarts even if durables are
offline and missing consumer TTL info because we know that we should ignore
proxy durables (bridge durables for other bridges) entirely because they will
be > 1 hop away.
4) Some other minor improvements were made like filtering everything if TTL
is 0 and also consolidating logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
