jeanouii commented on code in PR #1420:
URL: https://github.com/apache/activemq/pull/1420#discussion_r2042975500
##########
activemq-ra/src/main/java/org/apache/activemq/ra/ServerSessionImpl.java:
##########
@@ -64,8 +65,8 @@ public class ServerSessionImpl implements ServerSession,
InboundContext, Work, D
private MessageProducer messageProducer;
private final ServerSessionPoolImpl pool;
- private Object runControlMutex = new Object();
- private boolean runningFlag;
Review Comment:
This is a bit of a trick, because this avoids the lock but does not fix yet
the initial issue in my opinion. There is an underlying bug revealed by this
deadlock allowing another thread to be using this session to dispatch
unconsumed messages from a stale session (removeFromPool).
Trying to properly understand it, so I can push a more complete fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
