ViliusS commented on PR #5639:
URL: 
https://github.com/apache/activemq-artemis/pull/5639#issuecomment-2812021316

   Some context [how Google Error Reporting 
works](https://cloud.google.com/error-reporting/docs/grouping-errors#how_errors_are_grouped).
 It analyzes all log messages and tries to find exceptions in them. If 
exception is found monitoring agent is notified about new problem within an 
environment. If the same exception is found it is grouped and produces 
histogram, so monitoring agent can clearly see when the problem started to 
appear. See the following screenshot as an example:
   
![image](https://github.com/user-attachments/assets/44458a32-821f-4361-8a5c-f16cef51d778)
   If the error is marked as resolved and later reoccurs, monitoring agent is 
again notified, that the same error resurfaced.
   
   All of this is great except the part how Google Error Reporting 
differentiates between what is the same error and what is not. I'm not sure if 
it takes into account what is written after exception name (in Artemis case the 
part between []), but it definitely looks into full package name in the first 
line of the exception. If 
`org.apache.activemq.artemis.api.core.ActiveMQIllegalStateException` and 
`com.third.party.package.ActiveMQIllegalStateException` are found but exception 
structure just returns `ActiveMQIllegalStateException` in the first line it is 
treated as the same error case, which is not.
   
   This PR also would make exception format more inline with what how 
exceptions are returned from standard Java libraries. `java.lang` example:
   
![image](https://github.com/user-attachments/assets/fcdab4e3-9df9-4667-a010-dc276d8181ed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to