AntonRoskvist commented on PR #5593: URL: https://github.com/apache/activemq-artemis/pull/5593#issuecomment-2814026723
Thanks for reviewing @jbertram and @clebertsuconic. I believe I have found the issue for both points and I'm pushing my changes now, though I will make a second check tomorrow as well to make sure I didn't miss anything (running the full test suite takes some time on my work laptop). @jbertram I believe the addition of a short wait was all that's needed for the LVQ-test, please let me know if you think this is incorrect. @clebertsuconic Nice catch, with moving the `copyReference` logic over to use `iterQueue` I should have also removed synchronization of that method as that's now covered by the `iterQueue` logic. Again, I will run additional tests on this and update with what I find. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
