jbertram opened a new pull request, #5649:
URL: https://github.com/apache/activemq-artemis/pull/5649
The `temporary-queue-namespace` attribute was added via 6be8966 to deal with
the fact that when JMS clients create temporary destinations (e.g. via
`Session.createTemporaryQueue()` or `Session.createTemporaryTopic() ) a UUID is
used for the queue and/or address which means the name can't be matched via any
`address-setting` other than `#`.
The problem with this solution is that it was predicated on the fact that
the resources were temporary. However, it turns out that this was a red
herring. In the Core broker any queue can be a temporary queue and applying the
settings from the `temporary-queue-namespace` to temporary resources rather
than the actual match (if it exists) produces confusing and undesired results.
The real issue isn't that the resources are temporary, but rather that they
are named with a UUID. This commit changes the semantic so that the broker
detects the UUID name and applies the namespace based on that. It also does the
following:
- Deprecates `temporary-queue-namespace`
- Updates all relevant documentation
- Simplifies a bunch of code since we don't need to pass around a boolean
indicating whether the queue is temporary
- Adds tests for detecting valid UUIDs
- Implements proper support JMS temporary topics for AMQP, Core, and
OpenWire (including proper clean-up)
- Updates XML parser as well as XSD, etc. to support new parameter
- Adds support for `security-settings` for UUIDs which is now much simpler
than it would have been without this refactoring
UUID detection is off by default since the default value for
`uuid-namespace` is empty. I tried to ensure detection was as fast as possible
so when it is active it has a minimal impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
