GChuf commented on PR #82:
URL: 
https://github.com/apache/activemq-artemis-console/pull/82#issuecomment-2844415241

   @grgrzybek about the .env file - the only value beling replaced by webpack 
is PUBLIC_URL, and it's "hardcoded" into the webpack.config.cjs:
   ```
         new InterpolateHtmlPlugin(HtmlWebpackPlugin, {
           PUBLIC_URL: '/console'
         }),
   ```
         
   I don't think the .env file is used anywhere (I don't know webpack all that 
well), and if it is, it's redundant with this configuration anyway. Can you 
check and possibly remove the file?
   
   And if the link will always stay the same in index.html, 
InterpolateHtmlPlugin only unnecessarily makes things more complex.
   It would suffice to change the PUBLIC_URL to /hawtio in the index.html 
itself. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to