jbertram commented on PR #5718: URL: https://github.com/apache/activemq-artemis/pull/5718#issuecomment-2919504849
I'm not sure this is a good idea. For each one of these `CONNACK` properties the spec says something like: > If not present, then _________ are supported. Instead of hard-coding these flags to `1` and adding 4 extra bytes to every `CONNACK` we can simply omit them. This is why I didn't include them in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
