cshannon commented on code in PR #1445:
URL: https://github.com/apache/activemq/pull/1445#discussion_r2126540488
##########
activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java:
##########
@@ -120,17 +120,6 @@ protected static void setupFeatures(DocumentBuilderFactory
factory) {
}
}
}
- if (features.size() > 0) {
Review Comment:
Instead of removing this, I think it makes more sense to add an actual log
statement (probably debug level) as based on the comment that was the intent of
the loop. If we did that we should probably do a check to see if the log level
is enabled before doing the actual iteration and building of the buffer to
avoid the performance hit if not logging of building the string. I would also
switch to using StringBuilder as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
