jbertram commented on code in PR #5578:
URL: https://github.com/apache/activemq-artemis/pull/5578#discussion_r2164480213


##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/upgradeTest/CompareUpgradeTest.java:
##########
@@ -212,10 +211,7 @@ public void testWindows() throws Exception {
                                    "set ARTEMIS_HOME=", null, // no expected 
value for this, we will check on the output
                                    "set ARTEMIS_INSTANCE=", "\"" + windows + 
"\"",
                                    "set ARTEMIS_DATA_DIR=", "\"" + windowsData 
+ "\"",
-                                   "set ARTEMIS_ETC_DIR=", "\"" + windowsETC + 
"\"",
-                                   "set ARTEMIS_OOME_DUMP=", "\"" + windows + 
"/log/oom_dump.hprof\"",

Review Comment:
   This line was removed here simply because it was changed. See below at line 
214:
   ```
   "set ARTEMIS_OOME_DUMP=", "\"" + windows + "/log/oom_dump.hprof\"");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to