cshannon commented on PR #1474: URL: https://github.com/apache/activemq/pull/1474#issuecomment-3109660584
> This looks like a good set of changes to add robustness and the ability for the broker to recover from some IO errors without restart. > > I see the store() method has the handler-- any reason to not also add it to the load(Location )? > > ref: > > https://github.com/apache/activemq/blob/18e9b34dfe7e3227baf0be122a8db54020f48014/activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java#L1214 > > Seems like a _read_ is as (or more) recoverable than the store -- especially for network / cloud filesystems, etc. The goal of this PR is only to handle the runtime exception that migh be killing the tasks in KahaDB, not to try and change how IOExceptions are propagated or handled in general. So any other changes in terms of when we throw IO errors and what is and isn't recoverable would be a separate issue and outside the scope of this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
