GChuf commented on code in PR #110:
URL:
https://github.com/apache/activemq-artemis-console/pull/110#discussion_r2244715789
##########
artemis-console-extension/artemis-extension/packages/artemis-console-plugin/package.json:
##########
@@ -22,54 +21,57 @@
"replace-version": "replace __PACKAGE_VERSION_PLACEHOLDER__
$npm_package_version ./dist/index.js"
},
"dependencies": {
- "@hawtio/react": "1.9.2",
- "@patternfly/react-charts": "~7.4.9",
- "@patternfly/react-code-editor": "~5.4.18",
- "@patternfly/react-core": "~5.4.14",
- "@patternfly/react-icons": "~5.4.2",
- "@patternfly/react-styles": "~5.4.1",
- "@patternfly/react-table": "~5.4.16",
- "@patternfly/react-tokens": "~5.4.1",
- "@patternfly/react-topology": "~5.4.1",
- "d3": "^7.9.0",
- "react": "^18.3.1",
- "react-dom": "^18.3.1",
- "react-router-dom": "^6.30.0",
- "react-split": "~2.0.14",
- "xml-formatter": "3.6.5"
+ "react-split": "^2.0.14",
+ "xml-formatter": "^3.6.6"
},
"devDependencies": {
- "@hawtio/backend-middleware": "^1.0.6",
- "@jest/globals": "^29.7.0",
- "@swc/core": "^1.7.26",
- "@testing-library/dom": "^10.4.0",
- "@testing-library/jest-dom": "^6.6.3",
- "@types/react-test-renderer": "^19",
- "copy-webpack-plugin": "^12.0.2",
- "css-loader": "^7.1.2",
- "css-minimizer-webpack-plugin": "^7.0.0",
- "html-webpack-plugin": "^5.6.0",
- "jest": "^29.7.0",
- "jest-environment-jsdom": "^29.7.0",
- "mini-css-extract-plugin": "^2.9.1",
- "monaco-editor-webpack-plugin": "^7.1.0",
- "os-browserify": "^0.3.0",
- "path-browserify": "^1.0.1",
- "react-dev-utils": "^12.0.1",
- "react-test-renderer": "^19.1.0",
+ "@hawtio/react": "^1.10.1",
+ "@monaco-editor/react": "^4.6.0",
+ "@patternfly/react-charts": "^7.4.9",
+ "@patternfly/react-code-editor": "^5.4.18",
+ "@patternfly/react-core": "^5.4.14",
+ "@patternfly/react-icons": "^5.4.2",
+ "@patternfly/react-styles": "^5.4.1",
+ "@patternfly/react-table": "^5.4.16",
+ "@patternfly/react-tokens": "^5.4.1",
+ "@patternfly/react-topology": "^5.4.1",
+ "@testing-library/dom": "^10.4.1",
+ "@testing-library/jest-dom": "^6.6.4",
+ "@types/jest": "^30.0.0",
+ "@types/node": "^24.1.0",
+ "@types/react": "^18.3.23",
+ "@types/react-dom": "^18.3.7",
+ "@types/react-router-dom": "^5.3.3",
+ "jest": "^30.0.5",
+ "jest-environment-jsdom": "^30.0.5",
+ "jest-fetch-mock": "^3.0.3",
+ "monaco-editor": "^0.52.2",
+ "react": "^18.3.1",
+ "react-dom": "^18.3.1",
+ "react-router-dom": "^6.30.1",
"replace": "^1.2.2",
- "style-loader": "^4.0.0",
- "swc-loader": "^0.2.6",
- "terser-webpack-plugin": "^5.3.10",
- "ts-jest": "^29.3.2",
+ "ts-jest": "^29.4.0",
"ts-node": "^10.9.2",
- "tslib": "^2.8.1",
- "tsup": "^8.4.0",
+ "tsup": "^8.5.0",
"typescript": "^5.8.3",
- "undici": "^7.8.0",
- "webpack": "^5.99.0",
- "webpack-cli": "^5.1.4",
- "webpack-manifest-plugin": "^5.0.0"
+ "webpack": "^5.101.0"
Review Comment:
But webpack version is specified as a devDependency in both the package and
the app - isn't it enough to specify it as a peerDependency in package, and
only specify devDependency in app?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
