ViliusS commented on PR #109:
URL: 
https://github.com/apache/activemq-artemis-console/pull/109#issuecomment-3139373569

   @grgrzybek, the production build from your branch looks great. Monaco editor 
is loaded locally and SendMessage works.
   
   PatternFly chunk is much smaller, which is cool. I don't see 
`patternfly-mini-css-extract-plugin.js` either.
   
   ```
   [root@activemq-artemis-node-1 js]# ls -la *.js
   -rwxrwxrwx. 1 root root 116K Jul 31 10:04 786.cd3e7f0f.chunk.js
   -rwxrwxrwx. 1 root root 2.1K Jul 27 09:06 834.b7f74f9b.chunk.js
   -rwxrwxrwx. 1 root root 2.6K Jul 31 10:04 859.fd201182.chunk.js
   -rwxrwxrwx. 1 root root 2.6K Jul 31 10:04 862.45256e60.chunk.js
   -rwxrwxrwx. 1 root root 7.3M Jul 31 10:04 hawtio.4d3456bc.js
   -rwxrwxrwx. 1 root root  289 Jul 31 10:04 main.aeddac53.js
   -rwxrwxrwx. 1 root root 3.8M Jul 27 09:06 monaco.f3b534f1.chunk.js
   -rwxrwxrwx. 1 root root 1.4M Jul 31 10:04 other.30f5c573.chunk.js
   -rwxrwxrwx. 1 root root 992K Jul 31 10:04 patternfly.862b7cbd.js
   -rwxrwxrwx. 1 root root 152K Jul 27 09:06 react.52f8e43c.chunk.js
   -rwxrwxrwx. 1 root root 9.3K Jul 31 10:04 runtime.7ea245ba.js
   ```
   
   I still see some Monaco loader code in other.js chunk (search for string 
"https://cdn.";), but that probably is never loaded.
   
   I will close this PR in favour of yours, and move new discussion there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to