jbertram commented on code in PR #5847:
URL: https://github.com/apache/activemq-artemis/pull/5847#discussion_r2245811724
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java:
##########
@@ -494,8 +488,11 @@ private static boolean matchBinding(final Message message,
return false;
}
- final Filter filter = binding.getFilter();
+ if (CompositeAddress.isFullyQualified(message.getAddress()) &&
!binding.getClusterName().startsWith(CompositeAddress.extractQueueName(message.getAddressSimpleString())))
{
Review Comment:
Ensure the binding is an instance of `QueueBinding` would make it safer.
:+1:
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java:
##########
@@ -494,8 +488,11 @@ private static boolean matchBinding(final Message message,
return false;
}
- final Filter filter = binding.getFilter();
+ if (CompositeAddress.isFullyQualified(message.getAddress()) &&
!binding.getClusterName().startsWith(CompositeAddress.extractQueueName(message.getAddressSimpleString())))
{
Review Comment:
Ensuring the binding is an instance of `QueueBinding` would make it safer.
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
