therepanic commented on code in PR #1478:
URL: https://github.com/apache/activemq/pull/1478#discussion_r2257140784
##########
activemq-broker/src/main/java/org/apache/activemq/store/MessageStoreStatistics.java:
##########
@@ -28,24 +28,23 @@ public class MessageStoreStatistics extends StatsImpl {
protected CountStatisticImpl messageCount;
protected SizeStatisticImpl messageSize;
-
+ protected long createdTimestamp;
public MessageStoreStatistics() {
this(true);
}
public MessageStoreStatistics(boolean enabled) {
-
messageCount = new CountStatisticImpl("messageCount", "The number of
messages in the store passing through the destination");
messageSize = new SizeStatisticImpl("messageSize","Size of messages in
the store passing through the destination");
+ createdTimestamp = System.currentTimeMillis();
Review Comment:
Should we create another constructor where the second argument will be
`createdTimestamp`? Or is the current version OK?
##########
activemq-broker/src/main/java/org/apache/activemq/store/MessageStoreStatistics.java:
##########
@@ -28,24 +28,23 @@ public class MessageStoreStatistics extends StatsImpl {
protected CountStatisticImpl messageCount;
protected SizeStatisticImpl messageSize;
-
+ protected long createdTimestamp;
public MessageStoreStatistics() {
this(true);
}
public MessageStoreStatistics(boolean enabled) {
-
messageCount = new CountStatisticImpl("messageCount", "The number of
messages in the store passing through the destination");
messageSize = new SizeStatisticImpl("messageSize","Size of messages in
the store passing through the destination");
+ createdTimestamp = System.currentTimeMillis();
Review Comment:
Should we create another constructor where the second argument will be
`createdTimestamp` or is the current version OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
