AntonRoskvist commented on PR #5764:
URL: 
https://github.com/apache/activemq-artemis/pull/5764#issuecomment-3169261905

   Hi,
   
   Thanks for looking into this. Do note that I have two PRs pertaining to 
handling of compressed messages. This one and #5574.
   
   In this case (reported by another user), some handling of a compressed 
message can throw a `NegativeArraySizeException` which is demonstrated by the 
added test "testUpstreamFederatedAddressWithCompressedMessage". This is a 
fairly "straight forward" setup where the federation of a compressed message 
triggers the issue. Running that with no other changes will demonstrate the 
issue.
   
   While working on a test for this i also stumbled on some similar issue but 
that's triggered by a questionable use-case, where sending the same compressed 
message multiple times also gives the `NegativeArraySizeException` after a few 
sends. The included test "testCompressedMessageRouting" (which is not meant to 
be in the final PR) demonstrates the behavior with some added logging and code 
comments.
   
   #5574 on the other hand is about consumer credits getting out of balance 
when receiving and rollbacking a compressed "regular" message. It will give too 
many credits back so the consumerWindowSize will get larger and larger until an 
integer overflow happens (leaving the consumer "busy" until restarted).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to