AntonRoskvist commented on PR #5867:
URL: 
https://github.com/apache/activemq-artemis/pull/5867#issuecomment-3183031316

   I think this pretty much did it, except for one remaining issue: 
   
   Yesterday I made a change to the test 
`testUpstreamFederatedAddressWithCompressedMessage` [link 
here](https://github.com/AntonRoskvist/activemq-artemis/commit/fbae046a48707229a4927288105c6a618446eabb).
 Where I added federation of two more messages. One regular message and one 
regular that's been compressed. The latter fails to federate.
   
   I'm able to get it working by removing two lines in 
`ClientConsumerImpl.handleCompressedMessageSentAsRegular(..)`
   ```
   largeMessage.putBooleanProperty(Message.HDR_LARGE_COMPRESSED, false);
   //make sure the message is decompressed before it is handled
   largeMessage.checkCompletion();
   ```
    
    I am not seeing any side effects of this at the moment, though I see the 
call to `checkCompletion()` was added as part of the recent #5867
    
    I'm currently doing some more testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to