thezbyg commented on PR #1487: URL: https://github.com/apache/activemq/pull/1487#issuecomment-3287647778
The main issue is missing JMX value escaping. It could be fixed without any broker interface changes by adding JMXSupport.encodeObjectNamePart() calls in BrokerFacadeSupport.java file, but there is the following code that attempts to transform from JMX value to connection name that is displayed to user: https://github.com/apache/activemq/blob/fb781880e65a7bd4c6159567fc41edeb4d01cd63/activemq-web/src/main/java/org/apache/activemq/web/BrokerFacadeSupport.java#L178 JMX value escaping performed by JMXSupport.encodeObjectNamePart() is not reversible and it is impossible to get the original value from escaped value. There is no way to get original connection name as ConnectionViewMBean does not have a name property. This is the reason for interface changes. I can remove all other changes and leave only BrokerFacadeSupport.java changes if that is preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
