gemmellr commented on code in PR #5923: URL: https://github.com/apache/activemq-artemis/pull/5923#discussion_r2363001964
########## docs/user-manual/configuration-index.adoc: ########## @@ -110,19 +109,33 @@ acceptorConfigurations.tcp.params.host=localhost acceptorConfigurations.tcp.params.port=61616 ---- -would: 1) disable RBAC security checks 2) add or modify an acceptor named "tcp" that will use Netty 3) set the acceptor named "tcp" 'HOST' parameter to localhost 4) set the acceptor named "tcp" 'PORT' parameter to 61616 +.would: + . disable RBAC security checks + . add or modify an acceptor named "tcp" that will use Netty + . set the acceptor named "tcp" 'HOST' parameter to localhost + . set the acceptor named "tcp" 'PORT' parameter to 61616 -The configuration properties are low level, lower level than xml, however it is very powerful; -any accessible attribute of the internal `org.apache.activemq.artemis.core.config.impl.ConfigurationImpl` objects can be modified. +==== Attribute Names with Dots +Dots are significant in property keys because they identify the nesting level. If attribute names contain dots those need to be quoted. The quote string is specified via the property `key.surround` and has a default value of the double quote character: `"`. +An address setting, where the address contains dots, would be a typical example where quoting is required: +---- +addressSettings."Address.Name.With.Dots".expiryAddress=expiredMessages +---- + +The configuration properties are very low level, lower level than xml, which makes them very powerful. Review Comment: Everything after this point is content from the pre-existing parent section and seems to have nothing to do with the new 'attribute names with dots' subsection, so it seems entirely wrong to include it in that as this now does. Seems like the 'names with dots' subsection should be added _after_ the existing content in the section, prior to the 'Error Reporting' subsection, or else this bit needs its own new subsection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
