mattrpav commented on PR #1288: URL: https://github.com/apache/activemq/pull/1288#issuecomment-3339093258
@kenliao94 The changes look good, thanks! I want to take one last minute to discuss the naming, b/c these are public interfaces and once go out we are living with them for a long time. I think using a term that says what 'TotalUnsuppressedQueueCount' _is_ would be better than what it _isn't_. How about 'TotalManagedQueueCount' -- I think this terminology better describes what that number means. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
