tabish121 commented on code in PR #5942:
URL: https://github.com/apache/activemq-artemis/pull/5942#discussion_r2383432098
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4624,9 +4625,14 @@ public void reloadConfigurationFile() throws Exception {
}
private void reloadConfigurationFile(URL uri) throws Exception {
- Configuration config = new
FileConfigurationParser().parseMainConfig(uri.openStream());
- LegacyJMSConfiguration legacyJMSConfiguration = new
LegacyJMSConfiguration(config);
- legacyJMSConfiguration.parseConfiguration(uri.openStream());
+ Configuration config = null;
Review Comment:
This seems like it could put the configuration into a weird state if the
user provided some configuration in a ConfigurationImpl originally and some in
broker properties without using the XML file as any values in the bits that
aren't read from properties but then set onto the old configuration object
using the new initially empty one would blow away any existing values from the
starting ConfigurationImpl. Seems like at the very least we want to document
the limitations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
