brusdev commented on code in PR #5948:
URL: https://github.com/apache/activemq-artemis/pull/5948#discussion_r2399949202
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LegacyLDAPSecuritySettingPlugin.java:
##########
@@ -482,6 +541,14 @@ private void processSearchResult(Map<String, Set<Role>>
securityRoles,
}
}
+ private String convertDestinationWildcards(String destination) {
+ // Convert the OpenWire wildcard syntax to the corresponding Artemis
syntax
+ destination = OPENWIRE_WILDCARD.convert(destination,
wildcardConfiguration);
+ // The '$' character was used previously in LDAP entries to represent
the '>' character
+ destination = destination.replace('$',
wildcardConfiguration.getAnyWords());
Review Comment:
Inverting the order of the lines 546 and 548 and replacing `$` with `>`
would avoid replacing escaped `$`, i.e.
```suggestion
destination = destination.replace('$', '>');
destination = OPENWIRE_WILDCARD.convert(destination,
wildcardConfiguration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
