gemmellr commented on code in PR #5956:
URL: https://github.com/apache/activemq-artemis/pull/5956#discussion_r2426694965
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java:
##########
@@ -219,6 +220,16 @@ default void disconnect(DisconnectReason reason, String
targetNodeID, TransportC
*/
Subject getSubject();
+ /**
+ * sets the associated certificates for this connection
+ */
+ void setCertificates(X509Certificate[] certificates);
Review Comment:
It is roughly (left some feedback on specific issues with the changes), but
in hindsight I now wonder if Justin meant to suggest moving CertificateUtil
into `artemis-server` rather than `artemis-commons` as he actually did. Doing
that seems like it would be possible, and if so then the new field could
actually be restricted to NettyServerConnection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
