clebertsuconic commented on code in PR #5952:
URL: https://github.com/apache/activemq-artemis/pull/5952#discussion_r2406609969
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -1787,27 +1793,34 @@ public void close(final boolean failed, final boolean
force) {
context.reset();
}
+ final ScheduledFuture<?> scheduledFuture =
server.getScheduledPool().schedule(() -> {
+ callDoClose(failed);
+ logger.warn(ThreadDumpUtil.threadDump("Timed out closing session"));
+ }, timeoutSessionClose, TimeUnit.SECONDS);
+
context.executeOnCompletion(new IOCallback() {
@Override
public void onError(int errorCode, String errorMessage) {
- callDoClose();
+ scheduledFuture.cancel(true);
+ callDoClose(failed);
Review Comment:
it shouldn't really mater, but I am adding an extra property that will
control actually closed versus closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
