JeanLucGraphalo commented on code in PR #5956:
URL: https://github.com/apache/activemq-artemis/pull/5956#discussion_r2420330327
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java:
##########
@@ -219,6 +220,16 @@ default void disconnect(DisconnectReason reason, String
targetNodeID, TransportC
*/
Subject getSubject();
+ /**
+ * sets the associated certificates for this connection
+ */
+ void setCertificates(X509Certificate[] certificates);
Review Comment:
If I understand you correctly, the certificates should be cached in the
`NettyServerConnection` class. But then I would have to add an `artemis-server`
dependency to the `artemis-core-client` module in order to be able to use
`instanceof` in `CertificateUtil`.
Caching the certificates in
`org.apache.activemq.artemis.core.remoting.impl.netty.NettyConnection` would be
easier, but is probably not appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
