mattrpav commented on code in PR #1493:
URL: https://github.com/apache/activemq/pull/1493#discussion_r2388320753
##########
activemq-web-console/src/main/webapp/WEB-INF/tags/jms/forEachConnection.tag:
##########
@@ -23,9 +23,8 @@
<%
Iterator it = broker.getConnections(connectorName).iterator();
while (it.hasNext()) {
- String conName = (String) it.next();
- ConnectionViewMBean con = broker.getConnection(conName);
- request.setAttribute(connectionName, conName);
+ ConnectionViewMBean con = (ConnectionViewMBean) it.next();
+ request.setAttribute(connectionName, con.getClientId());
Review Comment:
Heads up-- iirc, there are inconsistencies in connection name/id/clientId.
Some protocols only allow a single clientId-per-broker (mqtt) and some can
in certain scenarios (jms). We need to be super sure about which is used to
avoid a scenario where the web ui can have two entries for the same id in a
list view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
