cshannon commented on PR #1119: URL: https://github.com/apache/activemq/pull/1119#issuecomment-3488571504
I did some testing and confirmed that things do seem to clean up ok on normal exception with the transport listener. However, I also confirmed that this patch will indeed destroy the thread pool [here](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/AbstractInactivityMonitor.java#L446) during connection initialization if there are no other connections yet, just to immediately re-create it again [here](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/AbstractInactivityMonitor.java#L476) because the stopConnectCheckTask() method is [called](https://github.com/asanguinetti/activemq/blob/e8cf40e24f3c8678ad1655ef2757d6b3d6186cfb/activemq-client/src/main/java/org/apache/activemq/transport/InactivityMonitor.java#L57) as part of the normal initialization of the connection before the monitor threads are created so that would be nice to avoid if the connection hasn't failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
