gemmellr commented on code in PR #6021:
URL: https://github.com/apache/activemq-artemis/pull/6021#discussion_r2495501196
##########
pom.xml:
##########
@@ -737,6 +744,30 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>jdk-17-23</id>
+ <activation>
+ <jdk>[17, 23]</jdk>
+ </activation>
+ <properties>
+ <activemq-surefire-argline>
+ ${initial-activemq-surefire-argline}
+ </activemq-surefire-argline>
+ </properties>
+ </profile>
+ <profile>
+ <id>jdk-25</id>
+ <activation>
+ <jdk>[24, 25]</jdk>
+ </activation>
+ <properties>
+ <activemq-surefire-argline>
+ ${initial-activemq-surefire-argline}
+ --enable-native-access=ALL-UNNAMED
+ --sun-misc-unsafe-memory-access=allow
+ </activemq-surefire-argline>
+ </properties>
+ </profile>
Review Comment:
The jdk25 profile is also set for 24 so should probably mention that in the
name.
It may be better to say [24, 26) rather than [24, 25], at least that was
always the historic recommendation, but its possible it no longer matters thee
days:
https://maven.apache.org/guides/introduction/introduction-to-profiles.html#JDK
Nitpick, but the several existing jdk related profiles skip the "-"
immediately after "jdk", so e.g "jdk24-25" would align better with them.
https://github.com/apache/activemq-artemis/blob/2.34.0/tests/integration-tests/pom.xml#L476-L484
That also shows the format used elsewhere by having a specific prop for the
additions, that is set empty to begin with then referenced in the original base
property, and then set to the alternative value in a profile when needed
meaning you only need the higher-version profile(s) for the additions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
