brusdev commented on code in PR #6024:
URL: https://github.com/apache/activemq-artemis/pull/6024#discussion_r2497853476
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/LDAPLoginModule.java:
##########
@@ -71,6 +71,20 @@ public class LDAPLoginModule implements AuditLoginModule {
private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final ThreadLocal<Map<String, String>>
environmentThreadLocal = new ThreadLocal<>();
Review Comment:
The idea `to use the login context initialise and shared state map to pass
the ssl env down to the socket factory` is smart however LoginContext doesn't
expose any public method to access it from the socket factory.
I agree that multiple LDAPLoginModule instances shouldn't be necessary. I
could use system properties instead of environmentThreadLocal to pass the SSL
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
