GChuf commented on PR #6027: URL: https://github.com/apache/activemq-artemis/pull/6027#issuecomment-3502005369
> Why would you want to have the option if you don't need the extra performance (assuming the main use-case here really is related to performance)? Maybe that was a poor choice of words ... I'll try to explain my reasoning as best as I can. I hope you can understand the tone of the message :) Need is a strong word. You could say that no-one needs the extra 10% when accessing the web console. Regardless, for the sake of this argument, let's say that I don't "need" this extra 10% at this moment, because the web console seems to be handling things ok. It's nice to have the option! though, because I might need it in the future. I'm expecting my broker to be under heavier loads, and my network to degrade ... etc. The other point I want to make is, that I'll take 2% improvement any day of the week, if all I need to do is change my proxy configuration from "127.0.0.1" to "/tmp/jetty.sock". From that point of view, this almost seems like a free lunch. > For example, 10% faster average load times for the web console using the default configuration ... Something like a 2-3% increase probably isn't worth the additional complexity (i.e. technical debt) here. I thought that's what you were getting at. This is also why I wanted some opinions. You're right, this adds additional complexity, and so the question is if it's worth it. Since I'm not an "expert" developer I'm not entirely sure how big the technical debt of adding this feature could potentially be. I've been trying to benchmark this today but I'm getting wildly different results while benchmarking the same instance - so I don't want to mention any numbers at this moment ... But I intend to post the results here once I'm able to reproduce them. I agree that this could fall under "premature optimization" if there's no real benefits of using this under heavy load on the broker and/or network ... or the web console. > What kind of decoupling did you have in mind? I was referring to network traffic, if we assume that all the netty connectors are on the same interface as jetty, but you've already mentioned different interfaces. > Can you elaborate on the security aspect here? I think most people would mention linux file permissions here, but I don't think I'm suited to defend that point of view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
