GChuf commented on PR #6034: URL: https://github.com/apache/activemq-artemis/pull/6034#issuecomment-3502371925
I should have mentioned a couple more things. The assembly changes were enough to fix the build in my case. So the .gitattributes file isn't needed to cover this specific case I was dealing with. While looking into it though, it still made sense to me to include those options (default, *.cmd and binaries, in case git itself doesn't see a file as a binary). A weird case here are .pem files, which i believe have mixed line endings(?). I did see a point in adding this file, but I'm also not opposed to dropping it. About the git index - not 100% sure what's happening ... There must be a default case of normalizing to LF somewhere like you say. I was trying to override LF with CRLF with the help of .gitattributes and running renormalize, or changing the endings myself/commiting a new file with CRLF. Running renormalize correctly updated those .java files that had CRLF line endings, with 0 issues. Running ls-files --eol correctly sets the *.cmd "attributes" to CRLF, but I never managed to update the index ... I expected the .gitattribute file would be enough. I also played around with autocrlf, tried it on both windows and linux, and tried re-cloning the repo to see if the situation would be different. > If you use the Jira key verbatim in the PR title ... I see, so it's linked with PR titles, not commits. That would explain why one of my previous PRs didn't get linked to jira. The hyphen got stripped in the PR title but I think that's a new behavior ... ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
