gemmellr commented on PR #6036: URL: https://github.com/apache/activemq-artemis/pull/6036#issuecomment-3504021049
I see you worked on this some more after opening+closing it, I'd give some pre-feedback if you are still working on suggested changes. - We would most likely stick to the separate cache action over the more basic 'setup-java built in' one, its more configurable, and there are some things outside the root pom the cache should sometimes consider so it definitely shouldnt be restricted to that. - The pre-cache cleanup shouldn't be removed entirely, we dont want it caching the build output which is being installed as certain bits need it to be, since caching that can (and has before) influence future builds and prevent catching certain issues as they happen rather than later on. - The maven download logging being there is actually desired, to see what being downloaded especially if its happening unexpectedly (most stuff is cached, except when being added). - I noticed you are also playing with -T1C to multithread the test runs specifically; various modules will run tests that cannot run at the same time, so that seems unlikely to be too reliable. The output is also a bit horrible (more so if you redirect the test output to console as we used to, and still will ocassionally). - Whilst I do use -T1C for most _builds_[-only] locally, and in other CI jobs elsewhere (since its already been compiled and checked here), we dont do so in these in-repo jobs in order to give the more comprehensible output when it barfs. Having the compile and other checks off in their own steps apart from the testing was partly for allowing that to be the case, as they happen at the same point and the overall run takes the same time with or without -T1C builds since the [tiny subset of the overall] tests it runs are the gating factor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
