gemmellr commented on code in PR #6054:
URL: https://github.com/apache/activemq-artemis/pull/6054#discussion_r2534576219
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1306,7 +1306,7 @@ Bindings simpleRoute(SimpleString address, RoutingContext
context, Message messa
}
if (bindings != null) {
bindings.route(message, context);
- if (addressInfo != null) {
+ if (addressInfo != null && context.getQueueCount() > 0) {
Review Comment:
Would it makes sense for simpleRoute to return null in this case, actually
holding to its previously-implied contract, rather than return the non-null
bindings and then requiring the caller to also know to check the Context (your
other change above) like this does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
