mattrpav commented on code in PR #1536:
URL: https://github.com/apache/activemq/pull/1536#discussion_r2534923927
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/scheduler/JobSchedulerImpl.java:
##########
@@ -797,6 +804,12 @@ protected void mainLoop() {
} finally {
this.store.readUnlockIndex();
+ // deferred execution of all jobs to be scheduled to avoid
deadlock with indexLock
+ for (Runnable command : toSchedule) {
+ command.run();
Review Comment:
I think we need some sort of catch-and-continue pattern here, since if
scheduling one fails due to IOException, the remaining would all fail to _try_
to schedule.
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/scheduler/JobSchedulerImpl.java:
##########
@@ -797,6 +804,12 @@ protected void mainLoop() {
} finally {
this.store.readUnlockIndex();
+ // deferred execution of all jobs to be scheduled to avoid
deadlock with indexLock
+ for (Runnable command : toSchedule) {
+ command.run();
Review Comment:
I think we may need some sort of catch-and-continue pattern here, since if
scheduling one fails due to IOException, the remaining would all fail to _try_
to schedule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
