jbertram commented on PR #6083: URL: https://github.com/apache/activemq-artemis/pull/6083#issuecomment-3554739069
I agree the mistake seems accidental, but I don't see how that's relevant. It's a bug that needs to be fixed and as far as consequences go, excessive memory usage is pretty bad, and that does ultimately affect functionality. I don't see how changing the class enough to write a test would do more harm than good. Also, I don't think either of the pools could be removed since they each contain a distinct type (i.e. `NullResponseMessage` & `NullResponseMessage_V2`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
