cshannon commented on PR #1541: URL: https://github.com/apache/activemq/pull/1541#issuecomment-3566914066
> Regarding migrating to JUnit 5/6: I agree that @category ā @tag and Surefire ā is straightforward. If your suggestion is to go that route instead, Iām perfectly fine with it. Vintage is deprecated but still available in JUnit 6, so it gives us some runway. Thanks for pointing out the @tag annotation, I read up a bit on it. I wasn't trying to say we should combine Junit 6 with the performance work, etc. just simply that I didn't want to make it harder to migrate. Many tests are easy to migrate from Junit 4 but some things are much harder (for example only in 5.13 did they finally add class level parameterized tests, etc). I wasn't sure if using the @Category tag was going to cause issues with the migration and further delay it, but because we can simply move to @Tag I think it's fine to go ahead with this PR. It looks pretty straight forward so it should not be an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
