lenoch7 commented on code in PR #1551:
URL: https://github.com/apache/activemq/pull/1551#discussion_r2567413326
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/cursors/FilePendingMessageCursor.java:
##########
@@ -263,16 +284,16 @@ public synchronized void addMessageFirst(MessageReference
node) {
memoryList.addMessageFirst(node);
node.incrementReferenceCount();
setCacheEnabled(true);
- return;
+ return expiredMessages;
}
}
if (!hasSpace()) {
if (isDiskListEmpty()) {
- expireOldMessages();
+ expiredMessages = expireOldMessages();
Review Comment:
Thank you for very quick feedback and analyze. I think, I got the point,
which you mean. But unfortunately I have no idea, how to change/improve it,
except the way you already mentioned - put new message to disk (temp storage)
immediately without attempt to "dispose" expired messages before switch to disk
(if I really got the point).
Maybe it will be better to close this PR without merge to give you more
comfortable way to make fix/changes/improvements. I am happy, you got the
problem, which I tried to report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
