cshannon commented on PR #1553: URL: https://github.com/apache/activemq/pull/1553#issuecomment-3599229256
> Looks good @cshannon > > Outside of this PR, I'm wondering if we could leverage ReentrantReadWrite lock to avoid this many synchronized methods? Replacing with a readwrite lock would only make sense if we could identify that it would actually help enough to justify the complexity. In a busy broker with messages being both written/read at the same time I'm not sure that is the case, it just kind of depends I guess on how it's being used and where lock contention is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
